msr_reader in c #5237
Merged
msr_reader in c #5237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
==========================================
+ Coverage 82.90% 82.95% +0.05%
==========================================
Files 250 250
Lines 26963 26963
==========================================
+ Hits 22354 22368 +14
+ Misses 4609 4595 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
read_msr_in_c
branch
from
f53b57d to
7bae90e
Compare
ShadowCurse
added
Status: Awaiting review
pb8o
reviewed
Jun 3, 2025
ShadowCurse
force-pushed
the
read_msr_in_c
branch
2 times, most recently
from
d852fcd to
a2bb2b9
Compare
pb8o
reviewed
Jun 4, 2025
ShadowCurse
force-pushed
the
read_msr_in_c
branch
2 times, most recently
from
2544958 to
71247bd
Compare
bchalios
previously approved these changes
Jun 4, 2025
pb8o
previously approved these changes
Jun 4, 2025
Rewrite `msr_reader.sh` script in C to speed up manual validation of msr baselines. Bash script run in ~1 minute. C version runs in 0.2 seconds. Signed-off-by: Egor Lazarchuk <[email protected]>
Bash script was formatting 0 as 0, while C version formats it as 0x0. Update to 0x0. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
read_msr_in_c
branch
from
71247bd to
a48f49b
Compare
bchalios
approved these changes
Jun 4, 2025
pb8o
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rewrite
msr_reader.shscript in C to speed up manual validation of msr baselines.Reason
Bash script run in ~1 minute. C version runs in 0.2 seconds.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.