test: do not run criterion benchmarks in no_block_pr #5273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5273 +/- ##
==========================================
+ Coverage 82.86% 82.91% +0.05%
==========================================
Files 250 250
Lines 26902 26902
==========================================
+ Hits 22292 22306 +14
+ Misses 4610 4596 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
added
the
Status: Awaiting review
roypat
reviewed
Jun 19, 2025
While I see your point, and how this test could become stale, I'm thinking how we'd run these benchmark on all instances if we needed in the future. Having this test in the codebase would save up some time, as it'd be just a manual test run through BK, and it's not trivial to replicate what this python file does. |
These tests have been failing consistently in our CI for as long as I can remember. While each individual test false positive rate is not high, the fact that we run many of them in a multitude of combinations means that at every CI run at least one fails. With this change, we are removing them from the PR - Optional step. We will still be able to notice performance regressions from the performance tests, so we're not losing much test coverage. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
disable-criterion
branch
from
036fd98 to
87c1549
Compare
roypat
approved these changes
Jun 26, 2025
roypat
approved these changes
Jun 26, 2025
roypat
approved these changes
Jun 26, 2025
10 tasks
kalyazin
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this change, we are disabling them in the PR - Optional step. We will still be able to notice performance regressions from the performance tests, so we're not losing much test coverage.
Reason
These tests have been failing consistently in our CI for as long as I can remember. While each individual test false positive rate is not high, the fact that we run many of them in a multitude of combinations means that at every CI run at least one fails.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.