Skip to content

Conversation

@kalyazin
Copy link
Contributor

Changes

Use ECR instead of docker.io to pull popular container images for tests.

Reason

This is to avoid rate limiter hits on the DockerHub side.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ ] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [ ] I have mentioned all user-facing changes in CHANGELOG.md.
  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • [ ] I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

This is to avoid rate limiter hits on the DockerHub side.

Signed-off-by: Nikita Kalyazin <[email protected]>
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (504b94d) to head (fc29dde).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5284      +/-   ##
==========================================
+ Coverage   82.86%   82.91%   +0.05%     
==========================================
  Files         250      250              
  Lines       26902    26902              
==========================================
+ Hits        22292    22306      +14     
+ Misses       4610     4596      -14     
Flag Coverage Δ
5.10-c5n.metal 83.35% <ø> (ø)
5.10-m5n.metal 83.34% <ø> (ø)
5.10-m6a.metal 82.56% <ø> (ø)
5.10-m6g.metal 79.17% <ø> (ø)
5.10-m6i.metal 83.34% <ø> (ø)
5.10-m7a.metal-48xl 82.55% <ø> (?)
5.10-m7g.metal 79.17% <ø> (ø)
5.10-m7i.metal-24xl 83.30% <ø> (?)
5.10-m7i.metal-48xl 83.30% <ø> (?)
5.10-m8g.metal-24xl 79.17% <ø> (?)
5.10-m8g.metal-48xl 79.17% <ø> (?)
6.1-c5n.metal 83.40% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 83.40% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 82.61% <ø> (ø)
6.1-m6g.metal ?
6.1-m6i.metal 83.38% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.60% <ø> (?)
6.1-m7g.metal 79.17% <ø> (ø)
6.1-m7i.metal-24xl 83.41% <ø> (?)
6.1-m7i.metal-48xl 83.41% <ø> (?)
6.1-m8g.metal-24xl 79.17% <ø> (?)
6.1-m8g.metal-48xl 79.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalyazin kalyazin self-assigned this Jun 30, 2025
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jun 30, 2025
Copy link
Contributor

@pb8o pb8o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm unrelated for this PR but maybe we should include 25.04 and drop 24.10 which will become unsupported in a few days.

Or ubuntu:latest to do that automatically from now on.

@kalyazin kalyazin merged commit 5b6769b into firecracker-microvm:main Jun 30, 2025
8 checks passed
@kalyazin kalyazin deleted the popular branch June 30, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants