Improve error handling in PciBdf de-serialization #5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly handle invalid Bdf by returning an error to the deserializer. This bug was caught by the fuzzer. Signed-off-by: Riccardo Mancini <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/pcie #5296 +/- ##
================================================
+ Coverage 80.16% 80.20% +0.04%
================================================
Files 265 265
Lines 30830 30832 +2
================================================
+ Hits 24715 24730 +15
+ Misses 6115 6102 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add some unit tests to cover PciBdf parsing, conversion, and (de)serialization. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
added
the
Status: Awaiting review
roypat
approved these changes
Jul 8, 2025
ShadowCurse
approved these changes
Jul 8, 2025
ShadowCurse
merged commit e8c599c
into
firecracker-microvm:feature/pcie
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add some error handling in the PciBdf de-serialization logic.
Also add some unit tests to make Coverage happy.
Reason
Fuzzer reported panics on random snapshot file due to this validation logic.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.