Skip to content

Conversation

@roypat
Copy link
Contributor

@roypat roypat commented Jul 8, 2025

Update the patch series from which the CI builds the secret hiding test kernel. Mainly, replace the v4 1 of the mmap-support series with the v12 2. Then rebase it on top of 6.16-rc3 to pick per-module exports that were merged for 6.16.

Update the direct map removal patches to what I locally have written for the upcoming v5, folding in the hotfix. Add a new patch that makes kvm-clock work with direct-map removed guest_memfd.

UFFD patches are just rebases, particularly KVM Userfault is still the v2.

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Update the patch series from which the CI builds the secret hiding test
kernel. Mainly, replace the v4 [1] of the mmap-support series with the
v12 [2]. Then rebase it on top of 6.16-rc3 to pick per-module exports
that were merged for 6.16.

Update the direct map removal patches to what I locally have written for
the upcoming v5, folding in the hotfix. Add a new patch that makes
kvm-clock work with direct-map removed guest_memfd.

UFFD patches are just rebases, particularly KVM Userfault is still the
v2.

[1]: https://lore.kernel.org/kvm/[email protected]/
[2]: https://lore.kernel.org/kvm/[email protected]/

Signed-off-by: Patrick Roy <[email protected]>
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (0f6b759) to head (fd82b68).
Report is 1 commits behind head on feature/secret-hiding.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/secret-hiding    #5297      +/-   ##
=========================================================
+ Coverage                  81.63%   81.77%   +0.14%     
=========================================================
  Files                        250      250              
  Lines                      27666    27666              
=========================================================
+ Hits                       22584    22624      +40     
+ Misses                      5082     5042      -40     
Flag Coverage Δ
5.10-c5n.metal 81.94% <ø> (ø)
5.10-m5n.metal 81.93% <ø> (ø)
5.10-m6a.metal 81.09% <ø> (ø)
5.10-m6g.metal 77.89% <ø> (ø)
5.10-m6i.metal 81.93% <ø> (+0.01%) ⬆️
5.10-m7a.metal-48xl 81.08% <ø> (?)
5.10-m7g.metal 77.89% <ø> (ø)
5.10-m7i.metal-24xl 81.90% <ø> (?)
5.10-m7i.metal-48xl 81.89% <ø> (?)
5.10-m8g.metal-24xl 77.89% <ø> (?)
5.10-m8g.metal-48xl 77.89% <ø> (?)
6.1-c5n.metal 81.98% <ø> (ø)
6.1-m5n.metal 81.97% <ø> (-0.01%) ⬇️
6.1-m6a.metal 81.14% <ø> (ø)
6.1-m6g.metal 77.89% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 81.97% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 81.13% <ø> (?)
6.1-m7g.metal 77.89% <ø> (ø)
6.1-m7i.metal-24xl 81.99% <ø> (?)
6.1-m7i.metal-48xl 81.99% <ø> (?)
6.1-m8g.metal-24xl 77.89% <ø> (?)
6.1-m8g.metal-48xl 77.89% <ø> (?)
6.14-c5n.metal 82.02% <ø> (?)
6.14-m5n.metal 82.02% <ø> (?)
6.14-m6a.metal 81.19% <ø> (?)
6.14-m6g.metal 77.94% <ø> (?)
6.14-m6i.metal 82.02% <ø> (?)
6.14-m7a.metal-48xl 81.18% <ø> (?)
6.14-m7g.metal 77.93% <ø> (?)
6.14-m7i.metal-24xl 82.04% <ø> (?)
6.14-m7i.metal-48xl 82.04% <ø> (?)
6.14-m8g.metal-24xl 77.93% <ø> (?)
6.14-m8g.metal-48xl 77.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roypat roypat enabled auto-merge (rebase) July 8, 2025 16:30
@roypat roypat merged commit 00f9feb into firecracker-microvm:feature/secret-hiding Jul 8, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants