Skip to content

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Jul 8, 2025

Changes

replaced HashMap with BTreeMap in the bpf filter compiler

Reason

In order to have reproducible builds on seccomp_filter.bpf (and so in the final binary package) . Followup from #3439

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@ilmanzo ilmanzo force-pushed the reproducible_build branch from ab24afb to d8dc72a Compare July 8, 2025 13:46
roypat
roypat previously approved these changes Jul 8, 2025
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jul 8, 2025
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (bccb658) to head (9095dbb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/seccompiler/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5298      +/-   ##
==========================================
+ Coverage   82.91%   82.96%   +0.05%     
==========================================
  Files         250      250              
  Lines       26880    26880              
==========================================
+ Hits        22288    22302      +14     
+ Misses       4592     4578      -14     
Flag Coverage Δ
5.10-c5n.metal 83.41% <0.00%> (-0.01%) ⬇️
5.10-m5n.metal 83.40% <0.00%> (ø)
5.10-m6a.metal 82.62% <0.00%> (ø)
5.10-m6g.metal 79.23% <0.00%> (ø)
5.10-m6i.metal 83.40% <0.00%> (ø)
5.10-m7a.metal-48xl 82.61% <0.00%> (?)
5.10-m7g.metal 79.23% <0.00%> (ø)
5.10-m7i.metal-24xl 83.36% <0.00%> (?)
5.10-m7i.metal-48xl 83.37% <0.00%> (?)
5.10-m8g.metal-24xl 79.23% <0.00%> (?)
5.10-m8g.metal-48xl 79.23% <0.00%> (?)
6.1-c5n.metal 83.46% <0.00%> (+<0.01%) ⬆️
6.1-m5n.metal 83.46% <0.00%> (+<0.01%) ⬆️
6.1-m6a.metal 82.67% <0.00%> (+<0.01%) ⬆️
6.1-m6g.metal 79.22% <0.00%> (-0.01%) ⬇️
6.1-m6i.metal 83.44% <0.00%> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.66% <0.00%> (?)
6.1-m7g.metal 79.23% <0.00%> (ø)
6.1-m7i.metal-24xl 83.47% <0.00%> (?)
6.1-m7i.metal-48xl 83.47% <0.00%> (?)
6.1-m8g.metal-24xl 79.23% <0.00%> (?)
6.1-m8g.metal-48xl 79.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilmanzo
Copy link
Contributor Author

ilmanzo commented Jul 8, 2025

Turns out we can use BTreeMap and avoid an extra dependency :)

replaced HashMap with BTreeMap in the bpf filter compiler

Signed-off-by: Andrea Manzini <[email protected]>
@ilmanzo ilmanzo force-pushed the reproducible_build branch from f71eef4 to 9095dbb Compare July 9, 2025 06:16
@roypat roypat enabled auto-merge (rebase) July 9, 2025 13:39
@roypat roypat merged commit a02fc1e into firecracker-microvm:main Jul 9, 2025
5 of 7 checks passed
@ilmanzo ilmanzo deleted the reproducible_build branch July 9, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants