chore: update patch series again #5302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Fuad's just-published v13 as the base, and disable CONFIG_KVM_KVM_XEN because the kvm-clock hack breaks it (and we also dont need it for Firecracker, so let's just disable for now until we have a proper kvmclock patch). Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5302 +/- ##
=========================================================
- Coverage 81.81% 81.77% -0.04%
=========================================================
Files 250 250
Lines 27666 27666
=========================================================
- Hits 22635 22624 -11
- Misses 5031 5042 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Fuad's just-published v13 as the base, and disable CONFIG_KVM_KVM_XEN because the kvm-clock hack breaks it (and we also dont need it for Firecracker, so let's just disable for now until we have a proper kvmclock patch).
This cannot be merged because CI is broken until #5293 is merged, but that PR isblocked on this PR fixing the kernels, so I'mma just push this commit to the feature branch once the "kernel builds" step of CI passed
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.