refactor(metrics): avoid temporary buffer when serializing metrics #5303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Metrics are currently serialized in a temporary buffer (String) before being written to the line buffered writer, which then writes finally to the file.
There is no need for this temporary buffer, as the metrics can be serialized directly into the writer.
We also need to manually write a newline as serde doesn't do that and we need it to separate the metric lines and flush the line writer.
Reason
I found this as I saw Firecracker was allocating and freeing memory every minute, causing pages to be mmap/munmap-ed periodically (and unnecessarily). This change removes these extra allocations, although the benefits are marginal at best as this action is only performed once a minute. Nonetheless, it's just 5 lines, so why not.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.