Skip to content

test(balloon): ensure we always wait long enough for stats to update #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

test(balloon): ensure we always wait long enough for stats to update #5325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30696e3
test(balloon): ensure we always wait long enough for stats to update
roypat Jul 24, 2025
bf54e18
Merge branch 'main' into balloon-more-delay
roypat Jul 24, 2025
5016ff6
Merge branch 'main' into balloon-more-delay
Manciukic Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/integration_tests/functional/test_balloon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def test_stats_update(uvm_plain_any):
test_microvm.api.balloon.patch(amount_mib=10)

# Wait out the polling interval, then get the updated stats.
time.sleep(STATS_POLLING_INTERVAL_S)
time.sleep(STATS_POLLING_INTERVAL_S * 2)
next_stats = test_microvm.api.balloon_stats.get().json()
assert initial_stats["available_memory"] != next_stats["available_memory"]

Expand Down Expand Up @@ -497,7 +497,7 @@ def test_balloon_snapshot(microvm_factory, guest_kernel, rootfs):
firecracker_pid = microvm.firecracker_pid

# Wait out the polling interval, then get the updated stats.
time.sleep(STATS_POLLING_INTERVAL_S)
time.sleep(STATS_POLLING_INTERVAL_S * 2)
stats_after_snap = microvm.api.balloon_stats.get().json()

# Check memory usage.
Expand All @@ -523,7 +523,7 @@ def test_balloon_snapshot(microvm_factory, guest_kernel, rootfs):
# Get the stats after we take a snapshot and dirty some memory,
# then reclaim it.
# Ensure we gave enough time for the stats to update.
time.sleep(STATS_POLLING_INTERVAL_S)
time.sleep(STATS_POLLING_INTERVAL_S * 2)
latest_stats = microvm.api.balloon_stats.get().json()

# Ensure the stats are still working after restore and show
Expand Down