Skip to content

feat(metrics): store dimensions alongside metrics in store_data #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

feat(metrics): store dimensions alongside metrics in store_data #5329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d27c7b
feat(metrics): store dimensions alongside metrics in store_data
Manciukic Jul 18, 2025
e0e262b
Merge branch 'main' into metric-properties
Manciukic Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions tests/host_tools/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,25 @@ class MetricsWrapper:
"""A convenient metrics logger"""

def __init__(self, logger):
self.data = {}
self.metrics = {}
self.dimensions = {}
self.logger = logger

def set_dimensions(self, *args, **kwargs):
def set_dimensions(self, *dimensions, **kwargs):
"""Set dimensions"""
if self.logger:
self.logger.set_dimensions(*args, **kwargs)
self.logger.set_dimensions(*dimensions, **kwargs)

self.dimensions = {}
for dimension_dict in dimensions:
for k, v in dimension_dict.items():
self.dimensions[k] = v

def put_metric(self, name, data, unit):
"""Put a datapoint with given dimensions"""
if name not in self.data:
self.data[name] = {"unit": unit, "values": []}
self.data[name]["values"].append(data)
if name not in self.metrics:
self.metrics[name] = {"unit": unit, "values": []}
self.metrics[name]["values"].append(data)

if self.logger:
self.logger.put_metric(name, data, unit)
Expand All @@ -88,7 +94,13 @@ def store_data(self, dir_path):
"""Store data into a file"""
metrics_path = Path(dir_path / "metrics.json")
with open(metrics_path, "w", encoding="utf-8") as f:
json.dump(self.data, f)
json.dump(
{
"metrics": self.metrics,
"dimensions": self.dimensions,
},
f,
)


def get_metrics_logger():
Expand Down