-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[PCIe] Performance fix for vsock device with pci disabled #5343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ShadowCurse
merged 2 commits into
firecracker-microvm:feature/pcie
from
Manciukic:pcie/vsock-perf-fix
Aug 5, 2025
Merged
[PCIe] Performance fix for vsock device with pci disabled #5343
ShadowCurse
merged 2 commits into
firecracker-microvm:feature/pcie
from
Manciukic:pcie/vsock-perf-fix
Aug 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3e31fa
to
409a567
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pcie #5343 +/- ##
================================================
- Coverage 80.68% 80.64% -0.05%
================================================
Files 265 265
Lines 30650 30675 +25
================================================
+ Hits 24731 24738 +7
- Misses 5919 5937 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bchalios
reviewed
Aug 4, 2025
409a567
to
fc24d8d
Compare
bchalios
reviewed
Aug 5, 2025
This method is used to notify the guest about queue events in a way that's most performant with the underlying interrupt implementation. As in IrqTrigger there is no distinction between different queues, it's best to send just one interrupt notifiying that "some queues" have a pending event. Conversely, in VirtioInterruptMsix, we need to trigger a MSI for each distinct queue. Signed-off-by: Riccardo Mancini <[email protected]>
We noticed that, compared to main, the vsock device is up to 30% slower when PCI is disabled. This is due to the refactor in 087e185 ("fix(vsock): pass correct index when triggering interrupts"), as we're now sending interrupts as soon as we detect the event, rather than deferring them and sending only one interrupt at the end. While with MSI we need to send multiple interrupts, so there is little difference (still, tests show up to 5% improvement with this change), with legacy IRQ there's only one interrupt line so we end up sending multiple back to back interrupts rather than a single one. This patch reverts to the previous behaviour and uses the newly introduced `trigger_queues` method to deduplicate interrupts in the case of IrqTrigger. Signed-off-by: Riccardo Mancini <[email protected]>
fc24d8d
to
db31697
Compare
bchalios
approved these changes
Aug 5, 2025
ShadowCurse
approved these changes
Aug 5, 2025
c9b0e64
into
firecracker-microvm:feature/pcie
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We noticed that, compared to main, the vsock device is up to 30% slower
when PCI is disabled. This is due to the refactor in 087e185 ("fix(vsock):
pass correct index when triggering interrupts"), as we're now sending
interrupts as soon as we detect the event, rather than deferring them
and sending only one interrupt at the end.
While with MSI we need to send multiple interrupts, so there is little
difference (still, tests show up to 5% improvement with this change),
with legacy IRQ there's only one interrupt line so we end up sending
multiple back to back interrupts rather than a single one.
This patch reverts to the previous behaviour and uses the newly
introduced
trigger_queues
method to deduplicate interrupts in the caseof IrqTrigger.
Reason
Improve performance of vsock device with PCI disabled by 30% and enabled by 5%.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.