-
Notifications
You must be signed in to change notification settings - Fork 2k
refactor: cleanup vmm::snapshot module #5355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roypat
wants to merge
4
commits into
firecracker-microvm:main
Choose a base branch
from
roypat:rustify
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+241
−324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5355 +/- ##
==========================================
+ Coverage 82.30% 82.32% +0.01%
==========================================
Files 265 265
Lines 30640 30580 -60
==========================================
- Hits 25219 25174 -45
+ Misses 5421 5406 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a typo in the output of the remove register operation. Fix it. Signed-off-by: Patrick Roy <[email protected]>
Have snapshot-editor always create a snapshot at the current version. We cannot load snapshots that have a different snapshot version than is supported by the running binary anyway (because strongly-typed deserialization would fail), so we statically know that the `version` parameter to `save_vmstate` is always `SNAPSHOT_VERSION`. Signed-off-by: Patrick Roy <[email protected]>
Implement the suggestions from firecracker-microvm#4523 to give a cleaner API for the snapshot module. Conceptually, the change is that we now store the thing we are snapshotting inside of the `Snapshot` struct. Implementation-wise, this allows us to deserialize the snapshot data in a single pass (instead of having to read it twice, once for deserialization and once for CRC validation), which means we do not have to first query the snapshot file for the size of the snapshot. Closes firecracker-microvm#4691, firecracker-microvm#4523, firecracker-microvm#5195 Signed-off-by: Patrick Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the suggestions from #4523 to give a cleaner API for the
snapshot module. Conceptually, the change is that we now store the thing
we are snapshotting inside of the
Snapshot
struct.Implementation-wise, this allows us to deserialize the snapshot data in
a single pass (instead of having to read it twice, once for
deserialization and once for CRC validation), which means we do not have
to first query the snapshot file for the size of the snapshot.
Closes #4691, #4523, #5195
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.