[feature/virtio-mem] Add dummy implementation for virtio-mem #5365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manciukic
force-pushed
the
feature/virtio-mem
branch
from
c9b0e64 to
80aa1de
Compare
Manciukic
changed the title
Manciukic
force-pushed
the
virtio-mem/dummy
branch
2 times, most recently
from
891017d to
904b043
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/virtio-mem #5365 +/- ##
======================================================
- Coverage 82.41% 82.37% -0.04%
======================================================
Files 266 270 +4
Lines 30571 30919 +348
======================================================
+ Hits 25194 25469 +275
- Misses 5377 5450 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update the Kconfig to enable support for virtio-mem in the guest. Signed-off-by: Riccardo Mancini <[email protected]>
virtio-mem requires a new Kconfig, so I've rebuilt the artifacts and now I'm making the devctr point to those. Signed-off-by: Riccardo Mancini <[email protected]>
Automatically generate bindings for virtio-mem. Signed-off-by: Riccardo Mancini <[email protected]>
Create the new module for the virtio-mem device. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
virtio-mem/dummy
branch
3 times, most recently
from
454ab3e to
c7b001b
Compare
Manciukic
added
the
Status: Awaiting review
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
roypat
reviewed
Aug 20, 2025
Allow to configure the virtio-mem device from the VmmConfig and the PUT API to /hotplug/memory. Signed-off-by: Riccardo Mancini <[email protected]>
Test the freshly added PUT API to /hotplug/memory. Signed-off-by: Riccardo Mancini <[email protected]>
Add a dummy virtio-mem device that is detected by the guest driver. The device is configured with total_size, block_size, and slot_size, and uses a fixed address after the MMIO64 memory zone. Signed-off-by: Riccardo Mancini <[email protected]>
Check that the driver correctly detects the virtio-mem device, with the correct parameters. Signed-off-by: Riccardo Mancini <[email protected]>
Add support for GET /hotplug/memory that returns the current status of the virtio-mem device. This API can only be called after boot. Signed-off-by: Riccardo Mancini <[email protected]>
Add new API to swagger and device-api.md Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
virtio-mem/dummy
branch
from
c7b001b to
6971326
Compare
ShadowCurse
approved these changes
Aug 21, 2025
roypat
approved these changes
Aug 22, 2025
|
I agree with all patrick comments, we discussed offline that since they're all nits we could have a commit to address them in the next PR. |
Manciukic
merged commit 832e565
into
firecracker-microvm:feature/virtio-mem
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a dummy implementation for virtio-mem device.
Add PUT and GET APIs for /hotplug/memory.
Reason
Support for Virtio Mem
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.