Skip to content

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Aug 13, 2025

Apparently, if a rust-vmm dep (currently vmm-sys-util) is included in a
PR for the firecracker group once, it will indefinitely be stuck in
there. So explicitly exclude these deps from that group, in hopes of
getting dependabot to understand that it should split the current PR
into two.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Apparently, if a rust-vmm dep (currently vmm-sys-util) is included in a
PR for the firecracker group _once_, it will indefinitely be stuck in
there. So explicitly exclude these deps from that group, in hopes of
getting dependabot to understand that it should split the current PR
into two.

Signed-off-by: Patrick Roy <[email protected]>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 13, 2025
@roypat roypat enabled auto-merge (rebase) August 13, 2025 09:20
@roypat roypat merged commit 09a8da6 into firecracker-microvm:main Aug 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants