chore: clarify network naming in network-setup.md #5386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
ShadowCurse
force-pushed
the
network_doc
branch
from
6dfb67e to
c937c43
Compare
ShadowCurse
added
Status: Awaiting review
Manciukic
reviewed
Aug 15, 2025
ShadowCurse
force-pushed
the
network_doc
branch
7 times, most recently
from
8a06ca3 to
9ecd766
Compare
roypat
reviewed
Aug 15, 2025
roypat
reviewed
Aug 15, 2025
roypat
reviewed
Aug 15, 2025
ShadowCurse
force-pushed
the
network_doc
branch
2 times, most recently
from
b0c875f to
4fff73e
Compare
Make it more clear that the `iface_id` is only used internally in Firecracker. Move information about the order of network interface creation and network interface names in the guest from FAQ into network-setup.md. Signed-off-by: Egor Lazarchuk <[email protected]>
There is no need to repeat that SendCtrlAltDel is x86_64 only when the header of the section says so already. Signed-off-by: Egor Lazarchuk <[email protected]>
Instead of **Note** syntax we can use GitHub version [!NOTE] to have a better visuals. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
network_doc
branch
from
4fff73e to
b62867f
Compare
roypat
approved these changes
Aug 20, 2025
Manciukic
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make it more clear that the
iface_idis only used internally in Firecracker.Move information about the order of network interface creation and network interface names in the guest from FAQ into network-setup.md.
Reason
Fixes: #5369
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.