Skip to content

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Aug 21, 2025

While it's a nice, rusty abstraction, it's really overkill here, given that we're using "100 lines to do the work of 5" (as Riccardo aptly put it).

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 21, 2025
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.40%. Comparing base (32a77ca) to head (c635783).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5398      +/-   ##
==========================================
+ Coverage   82.37%   82.40%   +0.03%     
==========================================
  Files         266      266              
  Lines       30580    30566      -14     
==========================================
  Hits        25189    25189              
+ Misses       5391     5377      -14     
Flag Coverage Δ
5.10-c5n.metal 82.38% <100.00%> (-0.02%) ⬇️
5.10-m5n.metal 82.38% <100.00%> (-0.01%) ⬇️
5.10-m6a.metal 81.66% <100.00%> (-0.01%) ⬇️
5.10-m6g.metal 78.98% <100.00%> (-0.02%) ⬇️
5.10-m6i.metal 82.38% <100.00%> (-0.01%) ⬇️
5.10-m7a.metal-48xl 81.65% <100.00%> (?)
5.10-m7g.metal 78.98% <100.00%> (-0.02%) ⬇️
5.10-m7i.metal-24xl 82.35% <100.00%> (?)
5.10-m7i.metal-48xl 82.35% <100.00%> (?)
5.10-m8g.metal-24xl 78.98% <100.00%> (?)
5.10-m8g.metal-48xl 78.98% <100.00%> (?)
6.1-c5n.metal 82.42% <100.00%> (-0.01%) ⬇️
6.1-m5n.metal 82.42% <100.00%> (-0.01%) ⬇️
6.1-m6a.metal 81.70% <100.00%> (-0.01%) ⬇️
6.1-m6g.metal 78.98% <100.00%> (-0.02%) ⬇️
6.1-m6i.metal 82.42% <100.00%> (-0.01%) ⬇️
6.1-m7a.metal-48xl 81.69% <100.00%> (?)
6.1-m7g.metal 78.98% <100.00%> (-0.02%) ⬇️
6.1-m7i.metal-24xl 82.43% <100.00%> (?)
6.1-m7i.metal-48xl 82.43% <100.00%> (?)
6.1-m8g.metal-24xl 78.98% <100.00%> (?)
6.1-m8g.metal-48xl 78.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roypat roypat force-pushed the no-crc-reader branch 2 times, most recently from c94a514 to 3d42535 Compare August 21, 2025 19:04
While it's a nice, rusty abstraction, it's really overkill here, given
that we're using "100 lines to do the work of 5" (as Riccardo aptly put
it).

Signed-off-by: Patrick Roy <[email protected]>
@Manciukic Manciukic merged commit e9c95b0 into firecracker-microvm:main Aug 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants