Skip to content

Conversation

Manciukic
Copy link
Contributor

@Manciukic Manciukic commented Aug 22, 2025

Changes

Store the vm type as an Arc in the constructor args for the MMIO dev mgr restore, as it's done in the PCI one. Also use a reference to avoid extra clones.

Reason

I will need to pass the Arc<Vm> to the virtio-mem device. It's already done like so in the PCI device manager, but not in MMIO.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Store the vm type as an Arc so it's going to be possible to pass it to
the virtio-mem device.

Signed-off-by: Riccardo Mancini <[email protected]>
@Manciukic Manciukic force-pushed the refactor/arc-vm-in-mmio-dev-mgr branch from 7a44cfe to b6584f0 Compare August 22, 2025 11:08
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.17%. Comparing base (031fb88) to head (dec94b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5401      +/-   ##
==========================================
+ Coverage   83.13%   83.17%   +0.04%     
==========================================
  Files         266      266              
  Lines       30530    30526       -4     
==========================================
+ Hits        25380    25390      +10     
+ Misses       5150     5136      -14     
Flag Coverage Δ
5.10-c5n.metal 83.23% <100.00%> (-0.01%) ⬇️
5.10-m5n.metal 83.23% <100.00%> (-0.01%) ⬇️
5.10-m6a.metal 82.54% <100.00%> (-0.01%) ⬇️
5.10-m6g.metal 79.86% <100.00%> (-0.01%) ⬇️
5.10-m6i.metal 83.23% <100.00%> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.53% <100.00%> (?)
5.10-m7g.metal 79.86% <100.00%> (-0.01%) ⬇️
5.10-m7i.metal-24xl 83.20% <100.00%> (?)
5.10-m7i.metal-48xl 83.20% <100.00%> (?)
5.10-m8g.metal-24xl 79.86% <100.00%> (?)
5.10-m8g.metal-48xl 79.86% <100.00%> (?)
6.1-c5n.metal 83.27% <100.00%> (-0.01%) ⬇️
6.1-m5n.metal 83.27% <100.00%> (-0.01%) ⬇️
6.1-m6a.metal 82.59% <100.00%> (+<0.01%) ⬆️
6.1-m6g.metal 79.86% <100.00%> (-0.02%) ⬇️
6.1-m6i.metal 83.27% <100.00%> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.58% <100.00%> (?)
6.1-m7g.metal 79.86% <100.00%> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.28% <100.00%> (?)
6.1-m7i.metal-48xl 83.28% <100.00%> (?)
6.1-m8g.metal-24xl 79.86% <100.00%> (?)
6.1-m8g.metal-48xl 79.86% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manciukic Manciukic marked this pull request as ready for review August 22, 2025 11:29
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 22, 2025
@ShadowCurse ShadowCurse merged commit 92e936d into firecracker-microvm:main Aug 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants