[feature/virtio-mem] basic snapshot/restore + metrics #5406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid multiple conversions back and forth from MiB to bytes by just storing as MiB. Signed-off-by: Riccardo Mancini <[email protected]>
We should match the exact reason for the RuntimeError to ensure we're failing for what we're expecting. Signed-off-by: Riccardo Mancini <[email protected]>
It's better to be explicit on the conversion we're doing as u64 to usize is always safe in our platforms. Signed-off-by: Riccardo Mancini <[email protected]>
This type annotation is redoundant, so we can remove it. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
virtio-mem/snapshot-restore
branch
from
c77404f to
c22249e
Compare
Manciukic
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/virtio-mem #5406 +/- ##
======================================================
+ Coverage 83.12% 83.18% +0.06%
======================================================
Files 270 272 +2
Lines 30875 31009 +134
======================================================
+ Hits 25666 25796 +130
- Misses 5209 5213 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
force-pushed
the
virtio-mem/snapshot-restore
branch
from
c22249e to
06d462e
Compare
Implements basic snapshot/restore functionality for the dummy virtio-mem device. Signed-off-by: Riccardo Mancini <[email protected]>
Wire support for virtio-mem metrics, adding a few basic metrics: queue events, queue event fails, activation fails. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
virtio-mem/snapshot-restore
branch
from
06d462e to
7c86819
Compare
Manciukic
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Sep 5, 2025
bchalios
approved these changes
Sep 8, 2025
Manciukic
merged commit 397f1d2
into
firecracker-microvm:feature/virtio-mem
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements basic snapshot restore functionality for virtio-mem device.
It also addresses a few nits from the previous PR.
And also adds basic metric support for the device.
Reason
Support snapshot/restore and metrics for this device.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.