-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore: update rust toolchain version #5413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5413 +/- ##
==========================================
- Coverage 83.13% 82.73% -0.40%
==========================================
Files 266 263 -3
Lines 30533 27455 -3078
==========================================
- Hits 25383 22715 -2668
+ Misses 5150 4740 -410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Current newest is 1.89.0 Signed-off-by: Patrick Roy <[email protected]>
63c745b
to
78cc556
Compare
Manciukic
previously approved these changes
Aug 27, 2025
4414edf
to
e2556f9
Compare
Lots of new warnings and lints Signed-off-by: Patrick Roy <[email protected]>
we go from v83 to v84. Ubuntu version of the base image changed during the container rebuild, so update that one python doctest. Signed-off-by: Patrick Roy <[email protected]>
It seems that with the newer kani versions, we need to explicitly pass --workspace to get it to pick up harnesses from within workspace crates. Signed-off-by: Patrick Roy <[email protected]>
Kani 0.65.0 crashes with ICE when trying to verify firecracker, see also model-checking/kani#4322 Signed-off-by: Patrick Roy <[email protected]>
e2556f9
to
f7d18ec
Compare
ShadowCurse
approved these changes
Aug 27, 2025
Manciukic
approved these changes
Aug 27, 2025
JackThomson2
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current newest is 1.89.0
Signed-off-by: Patrick Roy [email protected]## Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.