Skip to content

Conversation

Manciukic
Copy link
Contributor

@Manciukic Manciukic commented Sep 1, 2025

Changes

Backport of #5418 plus changelog entry and release preparation.

Reason

Fix typo in swagger.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Replace `imds_comat` with the correct `imds_compat`.

Fixes: firecracker-microvm#5417
Signed-off-by: Riccardo Mancini <[email protected]>
Fix another bunch of typos in the swagger spec descriptions. As these
are only in the description, this doesn't have any functional change to
code generation.

 - `s/snaphot/snapshot/`
 - `s/reponds/responds/`

Signed-off-by: Riccardo Mancini <[email protected]>
Add a changelod line for the typo fix.

Signed-off-by: Riccardo Mancini <[email protected]>
Add 1.13.1 to release policy.

Signed-off-by: Riccardo Mancini <[email protected]>
Update version number / CHANGELOG / CREDITS

Signed-off-by: Riccardo Mancini <[email protected]>
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (e4427c2) to head (4b7b023).
⚠️ Report is 5 commits behind head on firecracker-v1.13.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           firecracker-v1.13    #5419      +/-   ##
=====================================================
- Coverage              83.23%   83.23%   -0.01%     
=====================================================
  Files                    265      265              
  Lines                  30563    30563              
=====================================================
- Hits                   25440    25439       -1     
- Misses                  5123     5124       +1     
Flag Coverage Δ
5.10-c5n.metal ?
5.10-m5n.metal 83.30% <ø> (-0.02%) ⬇️
5.10-m6a.metal 82.61% <ø> (-0.02%) ⬇️
5.10-m6g.metal 79.93% <ø> (ø)
5.10-m6i.metal 83.30% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.60% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.93% <ø> (ø)
5.10-m7i.metal-24xl 83.27% <ø> (-0.01%) ⬇️
5.10-m7i.metal-48xl 83.27% <ø> (-0.01%) ⬇️
5.10-m8g.metal-24xl 79.93% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 79.93% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.34% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.66% <ø> (ø)
6.1-m6g.metal 79.93% <ø> (ø)
6.1-m6i.metal 83.34% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.65% <ø> (-0.01%) ⬇️
6.1-m7g.metal 79.93% <ø> (ø)
6.1-m7i.metal-24xl 83.35% <ø> (-0.01%) ⬇️
6.1-m7i.metal-48xl 83.35% <ø> (-0.01%) ⬇️
6.1-m8g.metal-24xl 79.93% <ø> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manciukic Manciukic changed the title [v1.13] Fix typo in swagger [v1.13] Fix typo in swagger and prepare 1.13.1 Sep 1, 2025
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 1, 2025
@Manciukic Manciukic marked this pull request as ready for review September 1, 2025 13:16
@Manciukic Manciukic merged commit f8d253a into firecracker-microvm:firecracker-v1.13 Sep 1, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants