Skip to content

Conversation

Manciukic
Copy link
Contributor

Changes

We increased the ext4 size from 400M to 500M in our devtool scripts, but not in the getting started. Let's bump it to 1G to avoid issues like this in the future.

Reason

The getting started is broken on the latest artifacts.

In the longer term, we may look into simplifying the getting started guide, but for now it's quicker to just fix the issue.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@Manciukic Manciukic marked this pull request as ready for review September 1, 2025 14:20
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 1, 2025
bchalios
bchalios previously approved these changes Sep 1, 2025
We increased the ext4 size from 400M to 500M in our devtool scripts,
but not in the getting started. Let's bump it to 1G to avoid issues like
this in the future.

In the longer term, we may look into simplifying the getting started
guide, but for now it's quicker to just fix the issue.

Fixes: firecracker-microvm#5349
Signed-off-by: Riccardo Mancini <[email protected]>
@Manciukic Manciukic enabled auto-merge (rebase) September 1, 2025 16:42
@Manciukic Manciukic merged commit 4a21dc6 into firecracker-microvm:main Sep 1, 2025
5 checks passed
@Manciukic Manciukic deleted the fix-getting-started branch September 1, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants