fix(test): correct operator precedence #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitshift shift has lower precedence than division, meaning in MemoryUsageExceededError.__init__ we end up trying to bitshift a float, which is nonsense (as the expression in the f-string gets interpreted as (threshold / 1) << 20, and the result of all divisions in python is a float). Add some parenthesis. We cannot just write this as `threshold >> 20`, as we care about the fractional part. Fixes: 7d1549f ("tests: fix MMIO gaps in memory monitor tool") Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Sep 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5434 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 263 263
Lines 27473 27473
=======================================
Hits 22717 22717
Misses 4756 4756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
approved these changes
Sep 8, 2025
Manciukic
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitshift shift has lower precedence than division, meaning in MemoryUsageExceededError.init we end up trying to bitshift a float, which is nonsense (as the expression in the f-string gets interpreted as (threshold / 1) << 20, and the result of all divisions in python is a float). Add some parenthesis.
We cannot just write this as
threshold >> 20, as we care about the fractional part.Fixes: 7d1549f ("tests: fix MMIO gaps in memory monitor tool")
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.