feat: specify readable ids for pci enable/disable fixture #5436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
Manciukic
previously approved these changes
Sep 10, 2025
kalyazin
reviewed
Sep 10, 2025
ShadowCurse
force-pushed
the
pci_fixture_fix
branch
from
6cfad17 to
4e16e20
Compare
ShadowCurse
force-pushed
the
pci_fixture_fix
branch
from
4e16e20 to
12c4c96
Compare
kalyazin
approved these changes
Sep 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5436 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 263 263
Lines 27473 27473
=======================================
Hits 22717 22717
Misses 4756 4756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Instead of ambiguous True/False use PCI/MMIO to better describe the underlying Firecracker device transport layer. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
pci_fixture_fix
branch
from
12c4c96 to
af8e0bb
Compare
roypat
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of ambiguous True/False use PCI/MMIO to better describe the underlying Firecracker device transport layer.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.