Gracefully clean-up potentially dead microVMs #5443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
force-pushed
the
graceful_killing_microvms
branch
from
9302beb to
1521d35
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5443 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 263 263
Lines 27301 27301
=======================================
Hits 22603 22603
Misses 4698 4698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
reviewed
Sep 17, 2025
We have some tests that stress the microVM in a way that _might_ cause it to die. We do check whether that's the case, however this is inherently racy, i.e. the microVM might die on us after the check but before the fixture logic tries to recycle it. Such a test is test_balloon.py::test_deflate_oom. In order to avoid such situations, teach MicroVM.kill() that there might be cases where the microVM process has already died and let it finish its cleanup gracefully. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
graceful_killing_microvms
branch
from
1521d35 to
c7b0bec
Compare
bchalios
added
the
Status: Awaiting review
Manciukic
approved these changes
Sep 17, 2025
JackThomson2
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Teach MicroVM.kill() that there might be cases where the microVM process has already died and let it finish its cleanup gracefully.
Reason
We have some tests that stress the microVM in a way that might cause it to die. We do check whether that's the case, however this is inherently racy, i.e. the microVM might die on us after the check but before the fixture logic tries to recycle it. Such a test is test_balloon.py::test_deflate_oom.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.