fix: correctly set device status to 0 on reset

[ShadowCurse]

Changes

Even though currently, no device supports resetting, once the guest attempts to reset the device we must set the status to 0 as specified in the 2.4.1 Device Requirements: Device Reset.

This does not change the current status of us not supporting device resetting.

Reason

This is the issue we encountered during addition of virtio-pmem device where the guest kernel now resets devices on VM shutdown.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

• I have read and understand CONTRIBUTING.md.
• I have run tools/devtool checkbuild --all to verify that the PR passes
  build checks on all supported architectures.
• I have run tools/devtool checkstyle to verify that the PR passes the
  automated style checks.
• I have described what is done in these changes, why they are needed, and
  how they are solving the problem in a clear and encompassing way.
• I have updated any relevant documentation (both in code and in the docs)
  in the PR.
• I have mentioned all user-facing changes in CHANGELOG.md.
• If a specific issue led to this PR, this PR closes the issue.
• When making API changes, I have followed the
  Runbook for Firecracker API changes.
• I have tested all new and changed functionalities in unit tests and/or
  integration tests.
• I have linked an issue to every new TODO.

---

• This functionality cannot be added in rust-vmm.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.78%. Comparing base (9fa26c3) to head (32dc596).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/vmm/src/devices/virtio/transport/pci/device.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5455   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files         263      263           
  Lines       27292    27292           
=======================================
  Hits        22594    22594           
  Misses       4698     4698           

Flag	Coverage Δ
5.10-m5n.metal	82.97% <0.00%> (ø)
5.10-m6a.metal	82.22% <0.00%> (ø)
5.10-m6g.metal	79.57% <0.00%> (+<0.01%)	⬆️
5.10-m6i.metal	82.96% <0.00%> (-0.01%)	⬇️
5.10-m7a.metal-48xl	82.21% <0.00%> (ø)
5.10-m7g.metal	79.57% <0.00%> (ø)
5.10-m7i.metal-24xl	82.93% <0.00%> (-0.01%)	⬇️
5.10-m7i.metal-48xl	82.93% <0.00%> (ø)
5.10-m8g.metal-24xl	79.56% <0.00%> (ø)
5.10-m8g.metal-48xl	79.56% <0.00%> (ø)
6.1-m5n.metal	83.00% <0.00%> (ø)
6.1-m6a.metal	82.26% <0.00%> (-0.01%)	⬇️
6.1-m6g.metal	79.56% <0.00%> (-0.01%)	⬇️
6.1-m6i.metal	83.00% <0.00%> (-0.01%)	⬇️
6.1-m7a.metal-48xl	82.25% <0.00%> (ø)
6.1-m7g.metal	79.56% <0.00%> (-0.01%)	⬇️
6.1-m7i.metal-24xl	83.01% <0.00%> (ø)
6.1-m7i.metal-48xl	83.01% <0.00%> (+<0.01%)	⬆️
6.1-m8g.metal-24xl	79.56% <0.00%> (-0.01%)	⬇️
6.1-m8g.metal-48xl	79.56% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bchalios]

I'm fine with the change. I'm not fine with the justification for it. We were explicitly setting it to FAILED because we don't support reset. Just setting this to DEVICE_RESET does not make us spec compliant since we don't actually do any resetting whatsoever.

I'm fine doing this for fixing the CI issue, but let's call it out (as well so we can keep track of why we did things).