Do not look into full path for error metric #5461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5461 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 263 263
Lines 27226 27226
=======================================
Hits 22541 22541
Misses 4685 4685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In order to collect all error metrics we're checking for "err" in the key name, which causes performance tests to fail because we added metrics called "intERRupts". Change the check to only look at the leaf of the path, so that when we have a metric such as `fc_metrics.net_metrics.cfg_fails`, we'll only be looking into `cfg_fails`. Suggested-by: Riccardo Mancini <[email protected]> Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
fix_err_metrics
branch
from
2a97221 to
2760e37
Compare
bchalios
changed the title
Manciukic
approved these changes
Oct 3, 2025
kalyazin
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to collect all error metrics we're checking for "err" in the key name, which causes performance tests to fail because we added metrics called "intERRupts". Change the check to only look at the leafof the path, so that when we have a metric such as
fc_metrics.net_metrics.cfg_fails, we'll only be looking into cfg_fails`.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.