Maintenance fixes #5465
Merged
Maintenance fixes #5465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
maintenance_1
branch
3 times, most recently
from
66328bf to
67e608c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5465 +/- ##
==========================================
- Coverage 82.79% 82.79% -0.01%
==========================================
Files 263 263
Lines 27226 27223 -3
==========================================
- Hits 22541 22538 -3
Misses 4685 4685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
added
Status: Awaiting review
ShadowCurse
force-pushed
the
maintenance_1
branch
from
67e608c to
5f2c100
Compare
ShadowCurse
force-pushed
the
maintenance_1
branch
from
5f2c100 to
4d27d83
Compare
bchalios
requested changes
Oct 7, 2025
ShadowCurse
force-pushed
the
maintenance_1
branch
from
4d27d83 to
d33eb2c
Compare
bchalios
reviewed
Oct 7, 2025
ShadowCurse
force-pushed
the
maintenance_1
branch
from
d33eb2c to
c9ef824
Compare
bchalios
previously approved these changes
Oct 7, 2025
ShadowCurse
force-pushed
the
maintenance_1
branch
from
c9ef824 to
3030131
Compare
We have a convention of not referring to Result type with full path since it is implicitly added to all namespaces. Additionally remove Result type redefinitions as we don't allow this. Signed-off-by: Egor Lazarchuk <[email protected]>
Instead of testing default implementations for avail_features_by_page and ack_features_by_page in rng and net devices, test it in device.rs Signed-off-by: Egor Lazarchuk <[email protected]>
Prefer proper error types over ambiguous anyhow errors. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
maintenance_1
branch
from
3030131 to
3c70033
Compare
bchalios
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
std::result::Resultand redefinitions ofResulttypeVirtioDevicedefinitionanyhowReason
Codebase maintenance
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.