Remove "ibpb_exit_to_user" from the host-only feature list if Amazon Linux #5473
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
force-pushed
the
ibpb_exit_to_user_on_ubuntu
branch
from
1c6127f to
837abb2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5473 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 263 263
Lines 27223 27223
=======================================
Hits 22538 22538
Misses 4685 4685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
previously approved these changes
Oct 8, 2025
zulinx86
added
the
Status: Awaiting review
ShadowCurse
previously approved these changes
Oct 8, 2025
zulinx86
force-pushed
the
ibpb_exit_to_user_on_ubuntu
branch
from
615948b to
49eef77
Compare
zulinx86
changed the title
Manciukic
previously approved these changes
Oct 9, 2025
Our test ubuntu host kernel hasn't backported the patch for VMScape [1]. Remove "ibpb_exit_to_user" from the host-minus-guest feature list only on Intel Cascade Lake that is the one where we run tests for Ubuntu. [1]: torvalds/linux@2f8f173 Signed-off-by: Takahiro Itazuri <[email protected]>
Now Ubuntu 24.04 AMI uses kernel v6.14. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
force-pushed
the
ibpb_exit_to_user_on_ubuntu
branch
from
6cea787 to
1c2c839
Compare
|
@Manciukic Sorry, I removed a debug-print line. Could I have another look? |
Manciukic
approved these changes
Oct 9, 2025
ShadowCurse
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove "ibpb_exit_to_user" from the host-only feature list if not Amazon Linux.
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
[ ] I have mentioned all user-facing changes inCHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.