Skip to content

Conversation

ShadowCurse
Copy link
Contributor

Changes

Add performance test for virtio-pmem device

Reason

Track some performance metrics over time

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse self-assigned this Oct 14, 2025
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (62abb81) to head (d9507a3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5479   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files         269      269           
  Lines       27798    27798           
=======================================
  Hits        23001    23001           
  Misses       4797     4797           
Flag Coverage Δ
5.10-m5n.metal 82.90% <ø> (ø)
5.10-m6a.metal 82.16% <ø> (ø)
5.10-m6g.metal 79.56% <ø> (ø)
5.10-m6i.metal 82.89% <ø> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.15% <ø> (ø)
5.10-m7g.metal 79.56% <ø> (ø)
5.10-m7i.metal-24xl 82.86% <ø> (ø)
5.10-m7i.metal-48xl 82.86% <ø> (-0.01%) ⬇️
5.10-m8g.metal-24xl 79.56% <ø> (ø)
5.10-m8g.metal-48xl 79.56% <ø> (ø)
6.1-m5n.metal 82.93% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 82.19% <ø> (ø)
6.1-m6g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m6i.metal 82.92% <ø> (ø)
6.1-m7a.metal-48xl 82.18% <ø> (ø)
6.1-m7g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m7i.metal-24xl 82.93% <ø> (ø)
6.1-m7i.metal-48xl 82.93% <ø> (ø)
6.1-m8g.metal-24xl 79.55% <ø> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShadowCurse ShadowCurse force-pushed the virtio_pmem_perf_tests branch 3 times, most recently from 85e89ce to 8f29e7c Compare October 14, 2025 12:31
@ShadowCurse ShadowCurse added the Type: Enhancement Indicates new feature requests label Oct 14, 2025
@ShadowCurse ShadowCurse marked this pull request as ready for review October 14, 2025 14:12
@ShadowCurse ShadowCurse force-pushed the virtio_pmem_perf_tests branch from 8f29e7c to 58a05b6 Compare October 14, 2025 14:48
@ShadowCurse ShadowCurse added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 14, 2025
@ShadowCurse ShadowCurse force-pushed the virtio_pmem_perf_tests branch from 58a05b6 to b25ba02 Compare October 15, 2025 11:11
@ShadowCurse ShadowCurse force-pushed the virtio_pmem_perf_tests branch 3 times, most recently from a79cf46 to 603e77f Compare October 15, 2025 13:48
@ShadowCurse ShadowCurse force-pushed the virtio_pmem_perf_tests branch from 603e77f to 668c4b4 Compare October 16, 2025 14:41
The fio commands will be used for virtio-pmem testing as
well, so move them into utils.

Signed-off-by: Egor Lazarchuk <[email protected]>
Add tests for maximum bandwidth
Add test for first full disk read

Signed-off-by: Egor Lazarchuk <[email protected]>
When VM is booted from virtio-pmem device with DAX,
it should use less guest page cache than VM booted
from virtio-block device

Signed-off-by: Egor Lazarchuk <[email protected]>
Parametrize the boottime tests to also test boottime
from virtio-pmem device.

Signed-off-by: Egor Lazarchuk <[email protected]>
In case we need to only run virtio-pmem performance tests.

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse force-pushed the virtio_pmem_perf_tests branch from 668c4b4 to eb7fb59 Compare October 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants