-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Virtio pmem perf tests #5479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShadowCurse
wants to merge
6
commits into
firecracker-microvm:main
Choose a base branch
from
ShadowCurse:virtio_pmem_perf_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Virtio pmem perf tests #5479
ShadowCurse
wants to merge
6
commits into
firecracker-microvm:main
from
ShadowCurse:virtio_pmem_perf_tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5479 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 269 269
Lines 27798 27798
=======================================
Hits 23001 23001
Misses 4797 4797
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
85e89ce
to
8f29e7c
Compare
8f29e7c
to
58a05b6
Compare
58a05b6
to
b25ba02
Compare
Manciukic
reviewed
Oct 15, 2025
Manciukic
reviewed
Oct 15, 2025
a79cf46
to
603e77f
Compare
603e77f
to
668c4b4
Compare
Manciukic
reviewed
Oct 16, 2025
The fio commands will be used for virtio-pmem testing as well, so move them into utils. Signed-off-by: Egor Lazarchuk <[email protected]>
Add tests for maximum bandwidth Add test for first full disk read Signed-off-by: Egor Lazarchuk <[email protected]>
When VM is booted from virtio-pmem device with DAX, it should use less guest page cache than VM booted from virtio-block device Signed-off-by: Egor Lazarchuk <[email protected]>
Parametrize the boottime tests to also test boottime from virtio-pmem device. Signed-off-by: Egor Lazarchuk <[email protected]>
In case we need to only run virtio-pmem performance tests. Signed-off-by: Egor Lazarchuk <[email protected]>
668c4b4
to
eb7fb59
Compare
Manciukic
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Enhancement
Indicates new feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add performance test for
virtio-pmem
deviceReason
Track some performance metrics over time
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.