feat(virtio-block): Add fallocate support #5511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
also disclaimer this still needs to be style checked, but this should be the near final implementation, other than writing a more rigorous testing suite. |
LDagnachew
force-pushed
the
unmap_fstrim_discard
branch
from
5bbb977 to
41e7941
Compare
Refactor unmap, fstrim, and discard logic to replace the deprecated discard_support branch and unify the block device discard path. Signed-off-by: LDagnachew <[email protected]>
LDagnachew
force-pushed
the
unmap_fstrim_discard
branch
from
41e7941 to
abda29f
Compare
Update Python files to comply with Black and pylint checks. These changes are formatting-only and do not alter functionality. Signed-off-by: LDagnachew <[email protected]>
LDagnachew
changed the title
Contributor
Author
|
@bchalios @ShadowCurse whenever you have time do y'all mind taking a look? I really want to bring this issue to the finish line, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fallocate.Reason
Attempting to resolve Issue #2708.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.