Maintenance 3

[ShadowCurse]

Changes

• fix clippy warnings
• replace u32 virtio device type with actual VirtioDeviceType enum
• add a common id method to VirtioDevice trait
• implement a common kick method in VirtioDevice trait that re-triggers queue eventfds instead of
  doing manual queue reprocessing

Reason

Maintenance

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

• I have read and understand CONTRIBUTING.md.
• I have run tools/devtool checkbuild --all to verify that the PR passes
  build checks on all supported architectures.
• I have run tools/devtool checkstyle to verify that the PR passes the
  automated style checks.
• I have described what is done in these changes, why they are needed, and
  how they are solving the problem in a clear and encompassing way.
• I have updated any relevant documentation (both in code and in the docs)
  in the PR.
• I have mentioned all user-facing changes in CHANGELOG.md.
• If a specific issue led to this PR, this PR closes the issue.
• When making API changes, I have followed the
  Runbook for Firecracker API changes.
• I have tested all new and changed functionalities in unit tests and/or
  integration tests.
• I have linked an issue to every new TODO.

---

• This functionality cannot be added in rust-vmm.

[codecov]

Codecov Report

❌ Patch coverage is 71.17117% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.22%. Comparing base (d61e343) to head (69af2c2).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
src/vmm/src/devices/virtio/device.rs	11.11%	16 Missing ⚠️
src/vmm/src/devices/virtio/balloon/device.rs	44.44%	5 Missing ⚠️
src/vmm/src/devices/virtio/vsock/device.rs	42.85%	4 Missing ⚠️
.../vmm/src/devices/virtio/block/vhost_user/device.rs	70.00%	3 Missing ⚠️
src/vmm/src/devices/virtio/pmem/device.rs	0.00%	3 Missing ⚠️
src/vmm/src/devices/virtio/block/device.rs	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5557      +/-   ##
==========================================
- Coverage   83.23%   83.22%   -0.02%     
==========================================
  Files         277      277              
  Lines       29262    29279      +17     
==========================================
+ Hits        24356    24367      +11     
- Misses       4906     4912       +6     

Flag	Coverage Δ
5.10-m5n.metal	83.56% <71.17%> (-0.01%)	⬇️
5.10-m6a.metal	82.89% <71.17%> (-0.02%)	⬇️
5.10-m6g.metal	80.17% <71.17%> (-0.03%)	⬇️
5.10-m6i.metal	83.56% <71.17%> (-0.01%)	⬇️
5.10-m7a.metal-48xl	82.89% <71.17%> (-0.01%)	⬇️
5.10-m7g.metal	80.17% <71.17%> (-0.02%)	⬇️
5.10-m7i.metal-24xl	83.53% <71.17%> (-0.02%)	⬇️
5.10-m7i.metal-48xl	83.54% <71.17%> (-0.01%)	⬇️
5.10-m8g.metal-24xl	80.17% <71.17%> (-0.02%)	⬇️
5.10-m8g.metal-48xl	80.17% <71.17%> (-0.03%)	⬇️
6.1-m5n.metal	83.59% <71.17%> (-0.01%)	⬇️
6.1-m6a.metal	82.92% <71.17%> (-0.01%)	⬇️
6.1-m6g.metal	80.16% <71.17%> (-0.03%)	⬇️
6.1-m6i.metal	83.59% <71.17%> (-0.01%)	⬇️
6.1-m7a.metal-48xl	82.92% <71.17%> (-0.01%)	⬇️
6.1-m7g.metal	80.17% <71.17%> (-0.03%)	⬇️
6.1-m7i.metal-24xl	83.60% <71.17%> (-0.01%)	⬇️
6.1-m7i.metal-48xl	83.60% <71.17%> (-0.02%)	⬇️
6.1-m8g.metal-24xl	80.17% <71.17%> (-0.03%)	⬇️
6.1-m8g.metal-48xl	80.17% <71.17%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.