Skip to content

Remove TODO in from_bytes_unchecked mac address builder #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackThomson2 merged 2 commits into from
Jan 8, 2026
Merged

Remove TODO in from_bytes_unchecked mac address builder #5607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9803b24
remove redunant todo regarding mac address init
aerosouund Jan 6, 2026
8650c20
Merge branch 'main' into remove-extra-init
JackThomson2 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/vmm/src/utils/net/mac.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ impl MacAddr {
/// * `src` - slice from which to copy MAC address content.
#[inline]
pub fn from_bytes_unchecked(src: &[u8]) -> MacAddr {
// TODO: using something like std::mem::uninitialized could avoid the extra initialization,
// if this ever becomes a performance bottleneck.
let mut bytes = [0u8; MAC_ADDR_LEN as usize];
bytes[..].copy_from_slice(src);

Expand Down