[1.13.1 Backport] feat(cargo-audit): install fresh cargo-audit on test run #5615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
ShadowCurse
force-pushed
the
v1.13_new_devctr
branch
from
9827bcd to
6bca959
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.13 #5615 +/- ##
==================================================
Coverage 83.23% 83.23%
==================================================
Files 265 265
Lines 30563 30563
==================================================
Hits 25439 25439
Misses 5124 5124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is an altered backport of firecracker-microvm#5614 which makes the `cargo-audit` test to always install the latest version of `cargo-audit`. In this version `--force` flag is used in order to overwrite already installed version in the devctr. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
v1.13_new_devctr
branch
from
6bca959 to
4715d72
Compare
Manciukic
approved these changes
Jan 8, 2026
JackThomson2
approved these changes
Jan 8, 2026
ShadowCurse
merged commit 6e59ef7
into
firecracker-microvm:firecracker-v1.13
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In order to prevent future
cargo-auditfailures of reading new new security database disclosures, removecargo-auditfrom dev container and always try to installcargo-auditfrom source instaed. This makes CI always use new version of the binary while for normal development, local version will be used (so no--forceflag).Reason
Keep cargo-audit up to date to prevent future false positive CI breakages.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.