Skip to content

Conversation

@kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Jan 9, 2026

Cherry pick from #5613 .

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

This is to fix pipelines while we're working on a migration to a
substitution.

(cherry picked from commit a61c603)
Signed-off-by: Nikita Kalyazin <[email protected]>
@kalyazin kalyazin self-assigned this Jan 9, 2026
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jan 9, 2026
@Manciukic
Copy link
Contributor

Manciukic commented Jan 9, 2026

nit: on the 1.14 branch the exclusion will probably be permanent, rather than temporary (I don't think we'll backport the replacement unless there are actual CVEs on bincode)
(I'm fine leaving the commit as is, just noting it down)

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (7137308) to head (20d8738).
⚠️ Report is 1 commits behind head on firecracker-v1.14.

Additional details and impacted files
@@                Coverage Diff                 @@
##           firecracker-v1.14    #5616   +/-   ##
==================================================
  Coverage              83.36%   83.36%           
==================================================
  Files                    277      277           
  Lines                  29252    29252           
==================================================
  Hits                   24387    24387           
  Misses                  4865     4865           
Flag Coverage Δ
5.10-m5n.metal 83.60% <ø> (ø)
5.10-m6a.metal 82.92% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.33% <ø> (ø)
5.10-m6i.metal 83.59% <ø> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.92% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.33% <ø> (ø)
5.10-m7i.metal-24xl 83.57% <ø> (ø)
5.10-m7i.metal-48xl 83.56% <ø> (-0.02%) ⬇️
5.10-m8g.metal-24xl 80.33% <ø> (+<0.01%) ⬆️
5.10-m8g.metal-48xl 80.33% <ø> (ø)
6.1-m5n.metal 83.62% <ø> (ø)
6.1-m6a.metal 82.96% <ø> (ø)
6.1-m6g.metal 80.33% <ø> (-0.01%) ⬇️
6.1-m6i.metal 83.62% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.94% <ø> (ø)
6.1-m7g.metal 80.33% <ø> (ø)
6.1-m7i.metal-24xl 83.63% <ø> (-0.01%) ⬇️
6.1-m7i.metal-48xl 83.63% <ø> (-0.02%) ⬇️
6.1-m8g.metal-24xl 80.33% <ø> (ø)
6.1-m8g.metal-48xl 80.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalyazin
Copy link
Contributor Author

kalyazin commented Jan 9, 2026

nit: on the 1.14 branch the exclusion will probably be permanent, rather than temporary (I don't think we'll backport the replacement unless there are actual CVEs on bincode) (I'm fine leaving the commit as is, just noting it down)

Fair, thanks for pointing out. Yes, I'd prefer to leave it as is as, if like you said, we have to patch, we'll lift it. Also it's probably lower mental load if cherry-picked patches are as close as possible to the originals.

@kalyazin kalyazin merged commit a4cfb3e into firecracker-microvm:firecracker-v1.14 Jan 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants