test(memory_monitor): run also for restored vms #5634
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we want to know the memory footprint for both booted and restored VMs. To avoid the extra latency from the GET /machine_config API call when running perf tests, only do it when the memory monitor is configured, which is likely disabled in perf tests. Signed-off-by: Nikita Kalyazin <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5634 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 277 277
Lines 29337 29337
=======================================
Hits 24423 24423
Misses 4914 4914
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
force-pushed
the
memmon
branch
3 times, most recently
from
d9a2d0c to
1cb5675
Compare
Free page hinting and reporting fragment guest memory VMAs and memory monitor cannot recognise them in order to exclude from the calculation of the Firecracker memory overhead. Signed-off-by: Nikita Kalyazin <[email protected]>
This is a performance test. Signed-off-by: Nikita Kalyazin <[email protected]>
kalyazin
added
the
Status: Awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Run memory monitor for restored VMs
Reason
Because we want to know the memory footprint for both booted and restored VMs.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.