fix: add missing lang and country params to search tool schema#179
Open
MaxwellCalkin wants to merge 1 commit intofirecrawl:mainfrom
Open
fix: add missing lang and country params to search tool schema#179MaxwellCalkin wants to merge 1 commit intofirecrawl:mainfrom
MaxwellCalkin wants to merge 1 commit intofirecrawl:mainfrom
Conversation
The firecrawl_search tool's description examples show lang and country parameters (e.g., "lang": "en", "country": "us"), but these were missing from the Zod schema. This causes validation errors when LLMs follow the documented examples. Both parameters are supported by the Firecrawl JS SDK's SearchParams interface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawl_searchtool's description examples showlangandcountryparameters ("lang": "en","country": "us"), but these were missing from the Zod schemaSearchParamsinterface (lang?: string,country?: string) and are supported by the Firecrawl APIDetails
The tool description (lines 546-564) includes this example:
{ "query": "latest AI research papers 2023", "limit": 5, "lang": "en", "country": "us", "sources": [{ "type": "web" }] }But the Zod schema only defined
query,limit,tbs,filter,location,sources,scrapeOptions, andenterprise— missinglangandcountry. Any MCP client LLM that followed the example would get a validation error.Test plan
npm run buildpasseslangandcountrymatch the SDK'sSearchParamsinterface{ query, ...opts }destructuring, so new params are automatically forwarded toclient.search()🤖 Generated with Claude Code