feat: shreds slot labels #151
Conversation
asuzuki-jumptrading
force-pushed
the
asuzuki/shreds-header
branch
2 times, most recently
from
a82c21e to
ebd5a6d
Compare
asuzuki-jumptrading
requested review from
amliu-jumptrading and
atsai-jumptrading
asuzuki-jumptrading
force-pushed
the
asuzuki/shreds-header
branch
2 times, most recently
from
2cd592b to
0e728a3
Compare
src/features/Overview/ShredsProgression/shredsProgressionPlugin.ts
Outdated
Show resolved
Hide resolved
src/features/Overview/ShredsProgression/shredsProgressionPlugin.ts
Outdated
Show resolved
Hide resolved
src/features/Overview/ShredsProgression/shredsProgressionPlugin.ts
Outdated
Show resolved
Hide resolved
src/features/Overview/ShredsProgression/shredsProgressionPlugin.ts
Outdated
Show resolved
Hide resolved
src/features/Overview/ShredsProgression/shredsProgressionPlugin.ts
Outdated
Show resolved
Hide resolved
asuzuki-jumptrading
force-pushed
the
asuzuki/shreds-header
branch
2 times, most recently
from
cb6e063 to
609e5d3
Compare
asuzuki-jumptrading
force-pushed
the
asuzuki/shreds-header
branch
from
609e5d3 to
7ab605a
Compare
asuzuki-jumptrading
force-pushed
the
asuzuki/shreds-header
branch
from
a11b865 to
c528ff6
Compare
| background-color: #080b13; | ||
| border-radius: 2px; | ||
| border: 1px solid #3c4652; | ||
| will-change: transform, width; |
There was a problem hiding this comment.
why is width needed here and below?
|
|
||
| const uplotRef = useRef<uPlot>(); | ||
| const lastRedrawRef = useRef(0); | ||
| const labelPositionsRef = useRef<LabelPositions>(); |
There was a problem hiding this comment.
don't get why we need this ref? This isn't used anywhere but the plugin right?
There was a problem hiding this comment.
This is so I can compare the last + current draw label positions, and not update width / x position if it hasn't changed
There was a problem hiding this comment.
but why a ref vs just making some vars in your plugin? Since you're not consuming the ref from anywhere outside the plugin
There was a problem hiding this comment.
or are you re-initializing your plugin and you need a stable reference?
| overflow="hidden" | ||
| position="relative" | ||
| // extra space for borders | ||
| height={`${height + 2}px`} |
There was a problem hiding this comment.
changing box sizing to border-box would work too i think?
There was a problem hiding this comment.
It doesn't seem to work with position: absolute 😢
No description provided.