chore: slot detail stats density and layout #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amliu-jumptrading
requested review from
asuzuki-jumptrading and
atsai-jumptrading
amliu-jumptrading
force-pushed
the
amliu/slot-details-layout
branch
from
f7898a3 to
665f4b7
Compare
| padding: 8px 16px; | ||
| background: var(--container-background-color); | ||
|
|
||
| &.bg { |
Collaborator
There was a problem hiding this comment.
Does this mean all cards will have this background? Are there any cases where we didn't want the bg?
| <CumulativeExecutionTimeStats /> | ||
| <ExecutionTime /> | ||
| </Flex> | ||
| <SlotDetailsSection title="Compute" flexBasis="0" flexGrow="2"> |
Collaborator
There was a problem hiding this comment.
Why is the flexBasis 0 needed here?
| <IncomeDistributionCharts /> | ||
| <IncomeScatterCharts /> | ||
| </Flex> | ||
| <SlotDetailsSection title="Fees" flexBasis="0" flexGrow="2"> |
Collaborator
There was a problem hiding this comment.
Same here with flexBasis 0
asuzuki-jumptrading
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.