gossip: fix contact info instance creation wallclock ser/der units

Author: ravyu-jump

src/flamenco/gossip/fd_gossip_msg_parse.c

@@ -311,7 +311,7 @@ fd_gossip_msg_crds_contact_info_parse( fd_gossip_view_crds_value_t * crds_val,
   INC( decode_u64_varint( payload, payload_sz, CUR_OFFSET, &wallclock ) );
   crds_val->wallclock_nanos = FD_MILLI_TO_NANOSEC( wallclock );
 
-  CHECK_LEFT( 8U ); crds_val->contact_info->instance_creation_wallclock_nanos = FD_MILLI_TO_NANOSEC( FD_LOAD( ulong, CURSOR ) ); INC(  8U );
+  CHECK_LEFT( 8U ); crds_val->contact_info->instance_creation_wallclock_nanos = FD_MICRO_TO_NANOSEC( FD_LOAD( ulong, CURSOR ) ); INC(  8U );
   CHECK_LEFT( 2U ); crds_val->contact_info->shred_version = FD_LOAD( ushort, CURSOR )                                          ; INC(  2U );
   INC( version_parse( crds_val->contact_info->version, payload, payload_sz, CUR_OFFSET ) );
 

src/flamenco/gossip/fd_gossip_msg_ser.c

@@ -242,7 +242,7 @@ fd_gossip_contact_info_encode( fd_contact_info_t const *     contact_info,
   ulong wallclock = (ulong)FD_NANOSEC_TO_MILLI( contact_info->wallclock_nanos );
   INC( varint_encode( wallclock, CURSOR ) );
 
-  ulong instance_creation_wallclock = (ulong)FD_NANOSEC_TO_MILLI( contact_info->instance_creation_wallclock_nanos );
+  ulong instance_creation_wallclock = (ulong)FD_NANOSEC_TO_MICRO( contact_info->instance_creation_wallclock_nanos );
   FD_STORE( ulong,  CURSOR, instance_creation_wallclock ); INC( 8UL );
   FD_STORE( ushort, CURSOR, contact_info->shred_version ); INC( 2UL );
 

src/flamenco/gossip/fd_gossip_private.h

@@ -48,10 +48,16 @@
 #define FD_GOSSIP_VALUE_RESTART_HEAVIEST_FORK         (13)
 #define FD_GOSSIP_VALUE_LAST                          (FD_GOSSIP_VALUE_RESTART_HEAVIEST_FORK)
 
-/* Gossip messages encode wallclock in millis, while we
-   parse them into nanoseconds for internal use. */
+/* Gossip messages encode wallclock in millis*, while we
+   parse them into nanoseconds for internal use.
+
+   * exceptions:
+     - Contact Info outset (AKA instance creation wallclock) is encoded
+       in micros */
 #define FD_NANOSEC_TO_MILLI(_ts_) ((long)(_ts_/1000000))
 #define FD_MILLI_TO_NANOSEC(_ts_) ((long)(_ts_*1000000))
+#define FD_NANOSEC_TO_MICRO(_ts_) ((long)(_ts_/1000))
+#define FD_MICRO_TO_NANOSEC(_ts_) ((long)(_ts_*1000))
 
 /* Bound max inc entries by
     1188b (max CRDS encoded buffer size )