runtime: new vote cache types [wip] #5968
Open
+1,586
−1,697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
| }; | ||
| typedef struct fd_vote_state_ele fd_vote_state_ele_t; | ||
|
|
||
| #define POOL_NAME fd_vote_state_pool |
mmcgee-jump
reviewed
Aug 7, 2025
| #define POOL_NEXT next_ | ||
| #include "../../util/tmpl/fd_pool.c" | ||
|
|
||
| #define MAP_NAME fd_vote_state_map |
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
src/flamenco/stakes/fd_vote_states.h
Outdated
| #define MAP_NEXT next_ | ||
| #include "../../util/tmpl/fd_map_chain.c" | ||
|
|
||
| struct fd_vote_states { |
mmcgee-jump
reviewed
Aug 7, 2025
| vote states uses to manage the vote states. */ | ||
|
|
||
| fd_vote_state_ele_t * | ||
| fd_vote_states_get_pool( fd_vote_states_t const * vote_states ); |
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
| fd_vote_states_get_pool( fd_vote_states_t const * vote_states ) { | ||
| FD_SCRATCH_ALLOC_INIT( l, vote_states ); | ||
| FD_SCRATCH_ALLOC_APPEND( l, fd_vote_states_align(), sizeof(fd_vote_states_t) ); | ||
| uchar * pool = FD_SCRATCH_ALLOC_APPEND( l, fd_vote_states_align(), fd_vote_states_footprint( vote_states->max_vote_accounts ) ); |
There was a problem hiding this comment.
Don't do this, save pointer or offset when you new the structure
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
src/flamenco/stakes/fd_vote_states.c
Outdated
| vote_states->magic = FD_VOTE_STATES_MAGIC; | ||
| vote_states->max_vote_accounts = max_vote_accounts; | ||
|
|
||
| if( FD_UNLIKELY( !fd_vote_state_pool_new( pool_mem, max_vote_accounts ) ) ) { |
There was a problem hiding this comment.
Not like this, do
vote_states->pool = fd_vote_state_pool_join( fd_vote_state_pool_new( .. ) );
FD_TEST( vote_states->pool );
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
mmcgee-jump
reviewed
Aug 7, 2025
ibhatt-jumptrading
force-pushed
the
ibhatt/new_vote_types
branch
from
0cbba17 to
71757af
Compare
…-io/firedancer into ibhatt/new_vote_types
mmcgee-jump
reviewed
Aug 13, 2025
| #define MAP_KEY_T fd_pubkey_t | ||
| #define MAP_ELE_T fd_vote_state_ele_t | ||
| #define MAP_KEY vote_account | ||
| #define MAP_KEY_EQ(k0,k1) (!(memcmp( &(k0)->key,&(k1)->key,sizeof(fd_pubkey_t) ))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.