solfuzz belt sanding #5970
Merged
solfuzz belt sanding #5970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ripatel-fd
commented
Aug 7, 2025
ripatel-fd
commented
- solfuzz: remove compute budget program fuzzer
- solfuzz: belt sanding
ripatel-fd
commented
Aug 7, 2025
ripatel-fd
commented
Aug 7, 2025
ripatel-fd
force-pushed
the
ripatel/solfuzz-belt-sand
branch
2 times, most recently
from
21e335e to
ad0856d
Compare
ripatel-fd
requested review from
mjain-jump,
ibhatt-jumptrading and
topointon-jump
mjain-jump
previously approved these changes
Aug 8, 2025
ripatel-fd
force-pushed
the
ripatel/solfuzz-belt-sand
branch
3 times, most recently
from
2e6e253 to
87d7f27
Compare
No longer maintained / used
ripatel-fd
force-pushed
the
ripatel/solfuzz-belt-sand
branch
from
87d7f27 to
e2bd228
Compare
- Flatten directory structure - Add venv to gitignore - Define and document separation of layers - Centralize memory management of 'solfuzz executor' - Use demand-paged THP workspace memory for solfuzz (Greatly reduces startup time with minimal prod perf impact) - Allow reusing a preallocated workspace for run-test-vectors
ripatel-fd
force-pushed
the
ripatel/solfuzz-belt-sand
branch
from
e2bd228 to
a147928
Compare
|
nice.. |
mjain-jump
reviewed
Aug 12, 2025
mjain-jump
reviewed
Aug 12, 2025
| #define DCACHE_DATA_SZ FD_DCACHE_REQ_DATA_SZ( PATH_MAX, MCACHE_DEPTH, 1UL, 1 ) | ||
| #define DCACHE_FOOTPRINT FD_DCACHE_FOOTPRINT( DCACHE_DATA_SZ, 0UL ) | ||
|
|
||
| static int fail_fast; |
There was a problem hiding this comment.
was this supposed to get set somewhere?
There was a problem hiding this comment.
Good catch. Not used at the moment but we could add a CLI argument in the future for it.
I just wanted to make sure to design the tile architecture and single-threaded mode to support it out of the box, since it would be hard to add later. Plumbing it through in a future commit should be an easy exercise.
mjain-jump
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.