snapshots: add initial peer selection #5982
Conversation
| int incremental_snapshot_fetch; | ||
| int do_download; | ||
| uint maximum_local_snapshot_age; | ||
| uint minimum_download_speed_mib; | ||
| uint maximum_download_retry_abort; | ||
| ulong initial_peers_cnt; | ||
| fd_ip4_port_t initial_peers[ 16 ]; |
There was a problem hiding this comment.
nit: alignment, also 16UL
| @@ -282,7 +282,8 @@ user = "" | |||
| # present. | |||
| # | |||
| # TODO: implement the "at most one downloaded " logic. " | |||
| download = true | |||
| # TODO: default to true once integrated with gossip | |||
| download = false | |||
There was a problem hiding this comment.
we should keep this as true because the snapshot loader has no way of knowing whether the snapshots on disk are recent right now.
There was a problem hiding this comment.
Having download as true involves setting an initial peer in the default config, which assumes a cluster. This needs to be a trusted peer too. This is partly the reason we removed hardcoded entrypoints in the first place. The user knows the target cluster and should set this field.
Second, I believe the download option isn't actually used anywhere in snapshot code apart from the config check I added.
There was a problem hiding this comment.
oh you are right, but we should check the download config option in the snapshot tiles.
No description provided.