flame: fixed perf->flamegraph to handle terminated processes #5992
Conversation
npatel-jump
force-pushed
the
npatel/flame-fix
branch
from
873be1c to
092950e
Compare
npatel-jump
force-pushed
the
npatel/flame-fix
branch
from
092950e to
67c934e
Compare
| @@ -58,7 +71,7 @@ flame_cmd_fn( args_t * args, | |||
| install_parent_signals(); | |||
|
|
|||
| fd_topo_join_workspaces( &config->topo, FD_SHMEM_JOIN_MODE_READ_ONLY ); | |||
| fd_topo_fill( &config->topo ); | |||
| fd_topo_fill_resilient( &config->topo ); | |||
There was a problem hiding this comment.
Why do you need this? The workspaces should still be valid?
| if( FD_UNLIKELY( -1==kill( (int)pid, 0 ) ) ) { | ||
| if( FD_UNLIKELY( errno==ESRCH ) ) FD_LOG_ERR(( "tile %s:%lu is not running", config->topo.tiles[ i ].name, config->topo.tiles[ i ].kind_id )); |
There was a problem hiding this comment.
I feel like changing this to WARNING should be pretty much the only change needed? Why all the other pid / tid bounds checks + resilient thing etc?
There was a problem hiding this comment.
The fd_topo_workspace_fill does FD_TEST's itself that fail (fseq checks).
For PID checks, I was getting many PID/TID's = 0, and a tid=438430872235253 for writer:1, and filtered around them so perf wouln't err due to a failed attachment.
I also think you previously had a check for it, so I included a similar filter to just continue on without them.
FD_TEST( pid<=INT_MAX );
There was a problem hiding this comment.
What FD_TEST would fail? I don't think that seems right
There was a problem hiding this comment.
It's failing on:
main src/disco/topo/fd_topo.c(178): tile net in_link_fseq[0] = (nil) main src/disco/topo/fd_topo.c(179): FAIL: tile->in_link_fseq[ j ]
I'll take a deeper look into why it might be failing
There was a problem hiding this comment.
Are you providing the config file to the flamegraph tool?
There was a problem hiding this comment.
Yes, but I just realized I was using the wrong one. That makes a lot more sense. Thank you, ill make the changes so it just fixes the warnings.
No description provided.