Skip to content

Fix additional shred destinations #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix additional shred destinations #5997

wants to merge 1 commit into from

Conversation

HGuillemet
Copy link
Contributor

The last commit of PR #5801 was incomplete, causing the new config directives to be ignored. Sorry about this.

Also both leader and received shreds were sent to additional_shred_destinations_retransmit. I believe it's better to keep both streams disjoint and only send received shreds to these destinations.

@nlgripto nlgripto requested a review from ripatel-fd August 10, 2025 20:47
@ripatel-fd
Copy link
Contributor

Thank you @HGuillemet. We're going to look into this on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptaffet-jump ptaffet-jump Awaiting requested review from ptaffet-jump ptaffet-jump is a code owner

@mmcgee-jump mmcgee-jump Awaiting requested review from mmcgee-jump mmcgee-jump is a code owner

@ripatel-fd ripatel-fd Awaiting requested review from ripatel-fd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HGuillemet @ripatel-fd