Fix additional shred destinations #5997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @HGuillemet. We're going to look into this on Monday. |
|
Apparently this fix has been forgotten for v705. |
Not forgotten, we just didn't get a chance to get the fix in because we were working on other things. Thank you for the reminder. |
anwayde
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit of PR #5801 was incomplete, causing the new config directives to be ignored. Sorry about this.
Also both leader and received shreds were sent to
additional_shred_destinations_retransmit. I believe it's better to keep both streams disjoint and only send received shreds to these destinations.