send_test: send tile test command and topology #6017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhinvasara-jumptrading
requested review from
nbridge-jump and
ripatel-fd
as code owners
akhinvasara-jumptrading
force-pushed
the
akhin/send_test
branch
2 times, most recently
from
cafac27 to
818c02f
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/send_test
branch
from
818c02f to
36e32c4
Compare
ripatel-fd
reviewed
Aug 12, 2025
ripatel-fd
reviewed
Aug 12, 2025
|
|
||
| if( config->is_firedancer ) { | ||
| CFG_HAS_POW2( tiles.repair.slot_max ); | ||
| } | ||
|
|
||
| CFG_HAS_NON_ZERO( tiles.metric.prometheus_listen_port ); | ||
|
|
||
| CFG_HAS_NON_ZERO( tiles.gui.gui_listen_port ); |
There was a problem hiding this comment.
Why did you remove these?
There was a problem hiding this comment.
Those ports need to be 0 when you want to run net tile without all of its out links (e.g. for send_test)...they should not be required in the base validation function. So I moved the check to run, where they are actually necessary. Chatted with @mmcgee-jump about this.
akhinvasara-jumptrading
force-pushed
the
akhin/send_test
branch
from
36e32c4 to
6e46750
Compare
ripatel-fd
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new firedancer-dev command to test the send tile. It will allow for rapid iteration on the quic client and vote performance, continuously testing the production send tile without depending on the rest of the full client.
This PR also adds socket support to the send tile.