runtime: fix account meta null check #8088
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
ripatel-fd
reviewed
Jan 31, 2026
| fd_accdb_rw_t const * ref = &txn_out->accounts.account[ idx_in_txn ]; | ||
|
|
||
| if( !ref || instr->is_duplicate[i] ) { | ||
| if( !ref->meta || instr->is_duplicate[i] ) { |
Contributor
There was a problem hiding this comment.
This does not look correct either way. All references in [0,instr->acct_cnt) should have a valid meta. For non-existent accounts, it points to zeros but it's still a valid pointer.
Contributor
Author
There was a problem hiding this comment.
At this point the acc should always exist, so removing this check
two-heart
force-pushed
the
two-heart/null-ref-check
branch
from
78de22a to
51432f4
Compare
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should took the reference, so this is not the NULL check we want