fuzz, capture: split up protobuf dumping and capture ctx #8129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
ripatel-fd
reviewed
Feb 2, 2026
mjain-jump
force-pushed
the
mjain/add-syscall-name-filters
branch
3 times, most recently
from
35cbc12 to
278d2a5
Compare
Performance Measurements ⏳
|
mjain-jump
force-pushed
the
mjain/add-syscall-name-filters
branch
from
2f99af3 to
278d2a5
Compare
Performance Measurements ⏳
|
mjain-jump
force-pushed
the
mjain/add-syscall-name-filters
branch
from
8143899 to
278d2a5
Compare
Performance Measurements ⏳
|
| void | ||
| fd_dump_vm_syscall_to_protobuf( fd_vm_t const * vm, | ||
| char const * fn_name ) { | ||
| char const * syscall_name_filter = vm->instr_ctx->runtime->log.dump_proto_ctx->dump_syscall_name_filter; |
Contributor
There was a problem hiding this comment.
a cleaner way to do this to avoid a strcmp for every syscall is to map the syscall function pointers to the syscall names so all you have to do is a pointer comparison
Contributor
Author
There was a problem hiding this comment.
theres no current map that does this, and this would also need to be maintained separately every time a new syscall is added, so i think the current implementation should be fine for now
mjain-jump
force-pushed
the
mjain/add-syscall-name-filters
branch
from
278d2a5 to
1e08dc1
Compare
Performance Measurements ⏳
|
ibhatt-jumptrading
approved these changes
Feb 3, 2026
Contributor
ibhatt-jumptrading
left a comment
ibhatt-jumptrading
left a comment
There was a problem hiding this comment.
don't love the function name strcmp but not blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.