Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the snapwm “vinyl” transactional commit path now that lthash verification makes the old duplicate-account handling unnecessary (per issue #8844).
Changes:
- Disallow
fd_snapwm_vinyl_txn_beginwhen lthash verification is enabled. - Simplify
fd_snapwm_vinyl_txn_commitby removing duplicate-account batching/lthash side paths and dropping thestemparameter. - Remove the now-unused duplicate-account lthash helper APIs from the snapwm private header and implementation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/discof/restore/fd_snapwm_tile_vinyl.c |
Adds lthash-enabled guard for txn begin; simplifies txn commit; removes duplicate-account lthash helper implementation. |
src/discof/restore/fd_snapwm_tile_private.h |
Updates txn API docs/signature; removes duplicate-account lthash helper declarations. |
src/discof/restore/fd_snapwm_tile.c |
Updates call site to match new fd_snapwm_vinyl_txn_commit signature. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
441
to
443
| /* Persist above erases to disk */ | ||
|
|
||
| int sync_err = fd_vinyl_io_sync( ctx->vinyl.io_mm, FD_VINYL_IO_FLAG_BLOCKING ); |
Contributor
Author
There was a problem hiding this comment.
This is not related to the PR. To be handled separately.
jvarela-jump
force-pushed
the
jvarela/snapwm-txn-commit-cleanup
branch
from
7381d4f to
a974fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snapwm vinyl
txn_commitdoes not need to handle duplicates anymore, and a cleanup was pending after the latest upgrade.Closes #8844.