frontend: developement updates#8946
Open
jherrera-jump wants to merge 1 commit intofiredancer-io:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the embedded development GUI frontend bundle (static assets) used by Firedancer’s fd_gui HTTP server, syncing dist_dev with a newer firedancer-frontend commit.
Changes:
- Bump
dist_dev/versionto frontend commitb899e07834b9101aef7ab1cb828250d0106a2ea9. - Refresh
dist_dev/index.htmlandgenerated/http_import_dist.cto reference the newly hashed JS/CSS and renamed circle logo assets. - Add the new
*_circle_logo-*.svgassets intodist_dev/assets/.
Reviewed changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/disco/gui/generated/http_import_dist.c |
Updates embedded dev static-file mappings/imports to match the new dist_dev asset filenames (logos + hashed JS/CSS). |
src/disco/gui/dist_dev/version |
Advances the pinned frontend commit hash for the dev bundle. |
src/disco/gui/dist_dev/index.html |
Points preloads and script/style tags at the updated asset filenames. |
src/disco/gui/dist_dev/assets/frankendancer_circle_logo-D5z79vwQ.svg |
Adds the new frankendancer circle logo asset. |
src/disco/gui/dist_dev/assets/firedancer_circle_logo-D9jlxCje.svg |
Adds the new firedancer circle logo asset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds firedancer-io/firedancer-frontend@ac4e5af...b899e07